Skip to contentSkip to conversation

Change in openvpn[master]: Add sample FFDH parameters file

Openvpn-devel In review mattock (Code Review) 2 participants 7 messages Aug 21, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1755776561000.I13ad2b7da6b008bc692b1f08f502fc3fc57e7206@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email

to review the following change.

Change subject: Add sample FFDH parameters file
......................................................................

Add sample FFDH parameters file

Change-Id I13ad2b7da6b008bc692b1f08f502fc3fc57e7206

---
A sample/sample-keys/ffdhe2048.pem
M tests/t_server_null_default.rc

2 files changed, 9 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1147/1

sample/sample-keys/ffdhe2048.pem new file +8 -0
new file mode 100644
index 0000000..9b182b7
@@ -0,0 +1,8 @@
+-----BEGIN DH PARAMETERS-----
+MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a
+87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD
+ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg==
+-----END DH PARAMETERS-----
tests/t_server_null_default.rc +1 -1
index 900f189..798cfd0 100755
@@ -13,7 +13,7 @@
 top_builddir="${top_builddir:-..}"
 sample_keys="${srcdir}/../sample/sample-keys"
 
-DH="${sample_keys}/dh2048.pem"
+DH="${sample_keys}/ffdhe2048.pem"
 CA="${sample_keys}/ca.crt"
 CLIENT_CERT="${sample_keys}/client.crt"
 CLIENT_KEY="${sample_keys}/client.key"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 1
Gerrit-Owner: mattock <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw

[Openvpn-devel] [S] Change in openvpn[master]: Add sample FFDH parameters file and use that in t_server_null tests

In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has uploaded a new patch set (#2) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email )

Change subject: Add sample FFDH parameters file and use that in t_server_null tests
......................................................................

Add sample FFDH parameters file and use that in t_server_null tests

Change-Id I13ad2b7da6b008bc692b1f08f502fc3fc57e7206

---
A sample/sample-keys/ffdhe2048.pem
M tests/t_server_null_default.rc

2 files changed, 9 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1147/2

sample/sample-keys/ffdhe2048.pem new file +8 -0
new file mode 100644
index 0000000..9b182b7
@@ -0,0 +1,8 @@
+-----BEGIN DH PARAMETERS-----
+MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a
+87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD
+ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg==
+-----END DH PARAMETERS-----
tests/t_server_null_default.rc +1 -1
index 900f189..798cfd0 100755
@@ -13,7 +13,7 @@
 top_builddir="${top_builddir:-..}"
 sample_keys="${srcdir}/../sample/sample-keys"
 
-DH="${sample_keys}/dh2048.pem"
+DH="${sample_keys}/ffdhe2048.pem"
 CA="${sample_keys}/ca.crt"
 CLIENT_CERT="${sample_keys}/client.crt"
 CLIENT_KEY="${sample_keys}/client.key"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 2
Gerrit-Owner: mattock <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newpatchset

#3 lore raw

[Openvpn-devel] [S] Change in openvpn[master]: Add sample FFDH parameters file and use that in t_server_null tests

In reply to a message not in the archive

Attention is currently required from: cron2, flichtenheld, mattock.

plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email )

Change subject: Add sample FFDH parameters file and use that in t_server_null tests
......................................................................

Patch Set 2: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 2
Gerrit-Owner: mattock <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: cron2 <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: mattock <[email protected]...>
Gerrit-Comment-Date: Thu, 21 Aug 2025 12:13:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#4 lore raw

PATCH v2 1/1 Add sample FFDH parameters file and use that in t_server_null tests

In reply to a message not in the archive

From: Samuli Seppänen <[email protected]...>

Change-Id I13ad2b7da6b008bc692b1f08f502fc3fc57e7206

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1147
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>

sample/sample-keys/ffdhe2048.pem new file +8 -0
new file mode 100644
index 0000000..9b182b7
@@ -0,0 +1,8 @@
+-----BEGIN DH PARAMETERS-----
+MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a
+87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD
+ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg==
+-----END DH PARAMETERS-----
tests/t_server_null_default.rc +1 -1
index 900f189..798cfd0 100755
@@ -13,7 +13,7 @@
 top_builddir="${top_builddir:-..}"
 sample_keys="${srcdir}/../sample/sample-keys"
 
-DH="${sample_keys}/dh2048.pem"
+DH="${sample_keys}/ffdhe2048.pem"
 CA="${sample_keys}/ca.crt"
 CLIENT_CERT="${sample_keys}/client.crt"
 CLIENT_KEY="${sample_keys}/client.key"
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: Add sample FFDH parameters file and use that in t_server_null tests

Thanks for this.

*This* time, the change is really fully Gerrit/BB and GHA tested, and all green. On the last commit Gerrit didn't want to test ("no code change") and I only pushed the 2.6 branch to GHA which does not have t_server_null .. *sigh*

Your patch has been applied to the master branch.

commit b60ba20c3d4021762eb1366f6a40fe5c8e6a95c8

Author: Samuli Seppänen
Date:   Thu Aug 21 14:14:34 2025 +0200
     Add sample FFDH parameters file and use that in t_server_null tests

     Signed-off-by: Samuli Seppänen <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg32643.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#6 lore raw

[Openvpn-devel] [S] Change in openvpn[master]: Add sample FFDH parameters file and use that in t_server_null tests

In reply to a message not in the archive

cron2 has uploaded a new patch set (#3) to the change originally created by mattock. ( http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos

Change subject: Add sample FFDH parameters file and use that in t_server_null tests
......................................................................

Add sample FFDH parameters file and use that in t_server_null tests

Change-Id I13ad2b7da6b008bc692b1f08f502fc3fc57e7206

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32643.html

---
A sample/sample-keys/ffdhe2048.pem
M tests/t_server_null_default.rc

2 files changed, 9 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1147/3

sample/sample-keys/ffdhe2048.pem new file +8 -0
new file mode 100644
index 0000000..9b182b7
@@ -0,0 +1,8 @@
+-----BEGIN DH PARAMETERS-----
+MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a
+87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD
+ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg==
+-----END DH PARAMETERS-----
tests/t_server_null_default.rc +1 -1
index 900f189..798cfd0 100755
@@ -13,7 +13,7 @@
 top_builddir="${top_builddir:-..}"
 sample_keys="${srcdir}/../sample/sample-keys"
 
-DH="${sample_keys}/dh2048.pem"
+DH="${sample_keys}/ffdhe2048.pem"
 CA="${sample_keys}/ca.crt"
 CLIENT_CERT="${sample_keys}/client.crt"
 CLIENT_KEY="${sample_keys}/client.key"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 3
Gerrit-Owner: mattock <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#7 lore raw

[Openvpn-devel] [S] Change in openvpn[master]: Add sample FFDH parameters file and use that in t_server_null tests

In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email )

Change subject: Add sample FFDH parameters file and use that in t_server_null tests
......................................................................

Add sample FFDH parameters file and use that in t_server_null tests

Change-Id I13ad2b7da6b008bc692b1f08f502fc3fc57e7206

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32643.html

---
A sample/sample-keys/ffdhe2048.pem
M tests/t_server_null_default.rc

2 files changed, 9 insertions(+), 1 deletion(-)
sample/sample-keys/ffdhe2048.pem new file +8 -0
new file mode 100644
index 0000000..9b182b7
@@ -0,0 +1,8 @@
+-----BEGIN DH PARAMETERS-----
+MIIBCAKCAQEA//////////+t+FRYortKmq/cViAnPTzx2LnFg84tNpWp4TZBFGQz
++8yTnc4kmz75fS/jY2MMddj2gbICrsRhetPfHtXV/WVhJDP1H18GbtCFY2VVPe0a
+87VXE15/V8k1mE8McODmi3fipona8+/och3xWKE2rec1MKzKT0g6eXq8CrGCsyT7
+YdEIqUuyyOP7uWrat2DX9GgdT0Kj3jlN9K5W7edjcrsZCwenyO4KbXCeAvzhzffi
+7MA0BM0oNC9hkXL+nOmFg/+OTxIy7vKBg8P+OxtMb61zO7X8vC7CIAXFjvGDfRaD
+ssbzSibBsu/6iGtCOGEoXJf//////////wIBAg==
+-----END DH PARAMETERS-----
tests/t_server_null_default.rc +1 -1
index 900f189..798cfd0 100755
@@ -13,7 +13,7 @@
 top_builddir="${top_builddir:-..}"
 sample_keys="${srcdir}/../sample/sample-keys"
 
-DH="${sample_keys}/dh2048.pem"
+DH="${sample_keys}/ffdhe2048.pem"
 CA="${sample_keys}/ca.crt"
 CLIENT_CERT="${sample_keys}/client.crt"
 CLIENT_KEY="${sample_keys}/client.key"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1147?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13ad2b7da6b008bc692b1f08f502fc3fc57e7206
Gerrit-Change-Number: 1147
Gerrit-PatchSet: 3
Gerrit-Owner: mattock <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged